Add LXC/LXD completions. #3554
Add LXC/LXD completions. #3554
Conversation
| end | ||
|
|
||
| function __fish_lxc_list_containers | ||
| lxc list -c n | grep '| \w' | sed -e 's/\(|\| \)*//g' |
There was a problem hiding this comment.
We prefer using our string tool for completions - string match -r '\| \w+' | string replace -r '\| ' ''?
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments monitor --description 'Monitor activity on the LXD server.' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments move --description 'Move containers within or in between lxd instances.' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments network --description 'Manage networks.' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments pauze --description 'Changes state of one or more containers to pause.' |
There was a problem hiding this comment.
Typo: I assume it's "pause"? Also "changes state to X" sounds a bit weird - why not just "pauses container" and similar for the other states.
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments delete --description 'Delete containers or container snapshots.' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments exec --description 'Execute the specified command in a container.' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments file --description 'Manage files on a container.' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments finger --description 'Fingers the LXD instance to check if it is up and working.' |
There was a problem hiding this comment.
"Check if the LXD instance is up"?
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments exec --description 'Execute the specified command in a container.' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments file --description 'Manage files on a container.' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments finger --description 'Fingers the LXD instance to check if it is up and working.' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments help --description 'Usage: lxc [subcommand] [options]' |
There was a problem hiding this comment.
This is the only one I had to depart from the lxc help <command> approach. I'll change it.
|
|
||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments config --description 'Manage configuration.' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments copy --description 'Copy containers within or in between lxd instances.' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments delete --description 'Delete containers or container snapshots.' |
There was a problem hiding this comment.
Would just "containers or snapshots" be okay here?
Descriptions should be as short as possible to allow more columns to be used.
There was a problem hiding this comment.
I agree with you that that text would be better. However, I took these texts directly from the lxc help <command> output. Leaving it would mean the original output is the One And Only Truth. I kinda like that too.
I'm a little on the fence here.
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments help --description 'Usage: lxc [subcommand] [options]' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments image --description 'Manipulate container images.' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments info --description 'List information on LXD servers and containers.' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments init --description 'Initialize a container from a particular image.' |
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments publish --description 'Publish containers as images.' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments remote --description 'Manage remote LXD servers.' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments restart --description 'Changes state of one or more containers to restart.' | ||
| complete --condition '__fish_lxc_no_subcommand' --command lxc --no-files --arguments restore --description 'Set the current state of a resource back to a snapshot.' |
There was a problem hiding this comment.
What's "resource" here? Something different from a container? A superset?
At the moment this covers only the most basic use cases. Texts are taken from `lxc help` command.
haarts
force-pushed
the
add-lxc-completions
branch
from
5a6e793
to
5b50744
Compare
|
@haarts: I'll leave the wording decisions up to you. Let me know when you've decided. |
|
@faho I'd like to echo the wording of LXD. But I agree with your suggestion. Lemme try to fix that upstream. In the meanwhile I think we should merge this. When upstream changes I'll create an other PR. |
|
Upstream issue: https://github.com/lxc/lxd/issues/2627 |
|
Merged, let's see what upstream thinks. |
Description
This adds (part of) the completions for LXD.
At the moment this covers only the most basic use cases.
Texts are taken from
lxc helpcommand.TODOs: